Apply various fixes #181
Apply various fixes #181
Conversation
(cherry picked from commit 7936865) Co-authored-by: Michal Nasiadka <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @cityofships, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on enhancing the stability and correctness of the Cephadm Ansible role. It introduces new validation steps to ensure proper environment setup, refines existing configuration logic for better accuracy, and updates development dependencies for broader compatibility. The changes aim to prevent common deployment issues and streamline the Cephadm automation process.
Highlights
- Dependency Updates: The
ansible-lintdependency intest-requirements.txthas been updated to allow for newer versions, specifically from<7to<26. - Ansible Role Robustness: New pre-checks have been added to
roles/cephadm/tasks/prechecks.ymlto assert the existence of required Ansible groups (ceph,mons,mgrs,osds) and to ensure that thecephadm_public_interfacevariable is set. This improves the robustness of the Cephadm Ansible role by catching common configuration issues early. - Cephadm Configuration Logic Improvements: The
roles/cephadm/tasks/bootstrap.ymlfile now conditionally applies theSet public networktask only whencephadm_public_networkis defined. Additionally, the logic for retrieving the Ceph cluster FSID has been refined to usecephadm ls --no-detailand parse its JSON output, making the FSID retrieval more accurate and reliable. Thecluster.yml.j2template also now uses a default filter forcephadm_admin_interfacefor more flexible variable assignment. - Gitignore Update: The
.gitignorefile has been updated to include/.ansible, preventing temporary Ansible files from being committed.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request introduces several fixes and improvements. It adds pre-flight checks for required inventory groups and variables, which is a great enhancement for usability. It also fixes how the cluster FSID is retrieved and makes host-specific configuration more flexible. My review includes a couple of suggestions: one to fix a potential bug when accessing host-specific variables in a template, and another to improve the readability and robustness of a complex variable definition.
Taken from #160